[feature] Add configurable default base image for steps#737
[feature] Add configurable default base image for steps#737CodeVishal-17 wants to merge 5 commits intokubeflow:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
CodeVishal-17
force-pushed
the
feat/base-image-config-727
branch
from
90f9e3e to
31a9831
Compare
|
@ada333 👋 As discussed, I've implemented the configurable base image support with priority: Would appreciate your review and feedback! |
Signed-off-by: Vishal <vishal.goyal7711@gmail.com>
CodeVishal-17
force-pushed
the
feat/base-image-config-727
branch
from
b63cde0 to
c2cfabb
Compare
|
@CodeVishal-17 thanks! Could you also add the UI changes so I can review it all at once? |
…efaults) Signed-off-by: Vishal <vishal.goyal7711@gmail.com>
@ada333 thanks! I’ve added the UI updates for base image configuration, including system and pipeline defaults. Would love your feedback. |
There was a problem hiding this comment.
@CodeVishal-17 thank you for the changes.
Please also add the default image setting in the jupyter lab settings and from the quick peak at your code I believe the UI will not display the default base image correctly.
BTW I am also thinking if there should be pipeline base image - that would be configurable on Left Panel I guess, I will discuss it with the team.
jesuino
left a comment
jesuino
left a comment
There was a problem hiding this comment.
This need more work on the client side. See CellMetadataEditor.tsx - it is not respecting the backend setting. I do believe the base image is hardcoded on client, you will need to retrieve it from the backend.
|
@CodeVishal-17 sorry for the confusion - so the solution should look like this (similar to cache setup):
|
…e UI updates Signed-off-by: Vishal <vishal.goyal7711@gmail.com>
Signed-off-by: Vishal Goyal <vishal.goyal7711@gmail.com>
|
@ada333 thanks for the feedback! I’ve added support for configuring the default base image via JupyterLab settings and updated the UI to correctly reflect the resolved value, including handling updates when the setting changes. |
jesuino
left a comment
jesuino
left a comment
There was a problem hiding this comment.
Please check the changes, looks like it is not even compiling anymore. Please make it sure it builds locally. Thanks!
|
@CodeVishal-17 hey, this issue is kind of a priority for us. Can you work on it? No problem if not, me or @jesuino can work on it but let me know please. |
@ada333 sorry for the delay was busy with my exams but now I am free and will actively work on the isse |
3 participants
Summary
Fixes #727
Adds support for configuring the default base image used for pipeline steps.
Changes
Introduced base image resolution priority:
image:...)base_image)DEFAULT_BASE_IMAGE)python:3.12)Updated compiler to use the resolved base image instead of a hardcoded default
Updated notebook processor to correctly apply fallback logic for step base images
Notes